fix(attendees): preserve member link on self-service ticket update without email - #588

…thout email

SummitAttendeeFactory::populate cleared the attendee's member link whenever
no member was passed in, even when the caller never intended a reassignment
(e.g. self-service ticket edits that don't send attendee_email). This caused
GET attendees/me to 404 transiently until MemberAssocSummitOrders re-linked
it by email on the next request. clearMember() is now reserved for explicit
reassignment attempts (an email was provided that doesn't match any member).

Ref: ClickUp 86bbcybah
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Signed-off-by: romanetar <roman_ag@hotmail.com>

…uns it

The CI matrix in .github/workflows/push.yml only executes tests/ subdirectories
(plus a few explicitly named root files); tests/AttendeeServiceTest.php lived at
the tests/ root and never ran, leaving the member-resolution branch added in
e59e1d9 unverified. Moving it into tests/Unit/Services/ puts it under the
existing "Services" shard.

…t the factory

SummitAttendeeFactory::populate is a shared populator used by ~15 call sites;
resolving member-by-email inside it meant AttendeeService::addAttendee/updateAttendee
silently linked an admin-submitted email to an existing member account even though
member_id and email are meant to be mutually exclusive alternatives on those
endpoints (summit-admin presents them as such). Move the lookup into addAttendee
and updateAttendee themselves, matching the pattern already used by
SummitOrderService, and keep the factory a pure populator.

Ref: PR #588 review comment (discussion_r3809508263)

…date

Add regression coverage for two paths reachable through the fix in e59e1d9
that had no test:
- updateMyTicketById: attendee_email isn't in its validation rules but
  isn't stripped either, so a stale/unmatched email can still reach
  SummitAttendeeFactory::populate and must still clear the member link.
- updateTicketByHash (public, hash-based edit link): its payload never
  carries an email, so the member link must survive an update, mirroring
  the no-email case already covered for updateMyTicketById.

Ref: PR #588 review comment (discussion_r3809509405)

…eTest

Moving this file into tests/Unit/Services/ (so CI actually runs it) exposed
three pre-existing latent bugs that never ran before:

- testRedeemPromoCodes hardcoded summit id 24, which only happened to match
  when the file ran standalone. Fixed to use the fixture's own summit id.
  Fixing that surfaced a separate, unrelated production issue in
  AttendeeService::updateRedeemedPromoCodes(): it makes a live, unmocked
  call to Eventbrite and then treats the Iterator-only response as an
  array, which is a guaranteed fatal Error in PHP 8. Left production code
  untouched (out of scope) and instead mocked IEventbriteAPI to fail fast,
  with the test now asserting the resulting exception deterministically.

- testReassignAttendeeTicketRegeneratesBadgeQRCode and
  testReassignAttendeeTicketByMemberRegeneratesBadgeQRCode both dispatch a
  RevocationTicketEmail, whose constructor requires an email template
  identifier resolved from SummitEmailEventFlowType. That catalog is only
  ever seeded by SummitEmailFlowTypeSeeder, which CI never runs. Added a
  small helper that seeds the minimal row directly in the test.

Ref: PR #588 CI run 32394478921, job 96508007715

…tests need

The previous fix only seeded RevocationTicketEmail's slug. CI run 32397343259
(job 96517140585) showed reassignAttendeeTicket(ByMember) also dispatch either
SummitAttendeeTicketEmail or InviteAttendeeTicketEditionMail to the new owner
(depending on whether their profile is already complete), and both hit the
same "missing template_identifier value" error. Seed all three slugs.

ResourceServerContext::getCurrentUser resets Member.email back to the
mocked token claim before the controller runs, undoing the artificial
drift and making the clear-member-link assertion unreachable.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

…email

addAttendee and updateAttendee resolve $member via email as a fallback
when no member_id is given, but skipped the getBySummitAndMember
duplicate check the member_id branch enforces. A member already linked
to another attendee in the summit (e.g. via a drifted, unmatched
stored email) could get linked to a second one, only to fail later on
the unique (MemberID, SummitID) index as an unhandled 500 instead of a
clean 412.

updateMyTicketById rejects any email other than the linked member's
current one (SummitOrderService guard), so the clear-link branch cannot
be reached through this endpoint.